Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Court class detail views #1803

Merged
merged 4 commits into from
Apr 25, 2024
Merged

Court class detail views #1803

merged 4 commits into from
Apr 25, 2024

Conversation

actlikewill
Copy link
Contributor

@actlikewill actlikewill commented Apr 23, 2024

  • This adds court class detail views along with some refactoring of the court views.

https://www.loom.com/share/cd7f7fc1d5e84a2a84260674a2458160?sid=0ab87cb8-ed23-45ae-a6e3-66ced1967695

closes laws-africa/kenyalaw-pj#31

@longhotsummer
Copy link
Contributor

Nice!

@actlikewill actlikewill marked this pull request as ready for review April 24, 2024 13:43
also increase padding between groups
@@ -12,6 +12,10 @@ <h4 class="mb-2">{{ court_class }}</h4>
</li>
{% endfor %}
</ul>
{% if court_class.show_listing_page %}
<a class="btn btn-sm btn-primary"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend we make this a simple link below the h4 heading, with class="mb-3" and text "All judgments"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea. this is how it looks now
image

Copy link
Contributor

@longhotsummer longhotsummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@actlikewill actlikewill merged commit 2902bcc into main Apr 25, 2024
9 checks passed
@actlikewill actlikewill deleted the courtclass-detail branch April 25, 2024 11:38
Copy link

sentry-io bot commented Apr 26, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ InterfaceError: connection already closed /judgments/{code}/{year}/ View Issue
  • ‼️ InterfaceError: connection already closed /judgments/{code}/{registry_code}/{year}/ View Issue
  • ‼️ InterfaceError: connection already closed /judgments/{code}/{year}/{month}/ View Issue
  • ‼️ InterfaceError: connection already closed /judgments/{code}/{year}/{month}/ View Issue
  • ‼️ InterfaceError: cursor already closed /judgments/{code}/{year}/ View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants